PG server updates to fix llvm issue + Spock 5.0.9 updates#22
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpgrade Spock from 5.0.8 to 5.0.9 across image package lists for amd64 and arm64 (Postgres 16.14, 17.10, 18.4), adjust Dockerfile pip install to a wildcard pattern and bump patroni to 4.1.3, and update build script to use spock_version=5.0.9. ChangesSpock 5.0.9 release upgrade
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 113: The dnf install call uses a wildcard RPM name
('python3-pip-21.3.1-*') which causes non-reproducible installs; introduce a
build ARG (e.g., PY3_PIP_NEVRA) and replace the wildcard with that exact NEVRA
value in the install command so the exact RPM is pinned, and use the same ARG
value for any later remove/cleanup (ensure the ARG is documented/defaulted in
the Dockerfile). Locate the install line that references python3-pip-21.3.1-*
and update it to use the new build argument (and update the corresponding
remove/cleanup invocation) so rebuilds use the exact NEVRA provided at build
time.
In `@scripts/build_pgedge_images.py`:
- Line 169: The script currently hardcodes package_release_channel="staging" in
multiple call sites; change those to read the channel from a configurable source
(e.g., an environment variable like PGEDGE_RELEASE_CHANNEL or a top-level config
variable) and default to "stable" when the env/config is unset; update all
occurrences that set package_release_channel (the three places shown) to use the
new config variable (or os.environ.get fallback) so builds can target the proper
release channel instead of always forcing "staging".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f9a153c4-d040-4a3f-9d21-b59148b2b1d0
📒 Files selected for processing (20)
Dockerfilepackagelists/amd64/pg16.14-spock5.0.8-minimal.txtpackagelists/amd64/pg16.14-spock5.0.9-minimal.txtpackagelists/amd64/pg16.14-spock5.0.9-standard.txtpackagelists/amd64/pg17.10-spock5.0.8-minimal.txtpackagelists/amd64/pg17.10-spock5.0.9-minimal.txtpackagelists/amd64/pg17.10-spock5.0.9-standard.txtpackagelists/amd64/pg18.4-spock5.0.8-minimal.txtpackagelists/amd64/pg18.4-spock5.0.9-minimal.txtpackagelists/amd64/pg18.4-spock5.0.9-standard.txtpackagelists/arm64/pg16.14-spock5.0.8-minimal.txtpackagelists/arm64/pg16.14-spock5.0.9-minimal.txtpackagelists/arm64/pg16.14-spock5.0.9-standard.txtpackagelists/arm64/pg17.10-spock5.0.8-minimal.txtpackagelists/arm64/pg17.10-spock5.0.9-minimal.txtpackagelists/arm64/pg17.10-spock5.0.9-standard.txtpackagelists/arm64/pg18.4-spock5.0.8-minimal.txtpackagelists/arm64/pg18.4-spock5.0.9-minimal.txtpackagelists/arm64/pg18.4-spock5.0.9-standard.txtscripts/build_pgedge_images.py
💤 Files with no reviewable changes (6)
- packagelists/amd64/pg16.14-spock5.0.8-minimal.txt
- packagelists/arm64/pg18.4-spock5.0.8-minimal.txt
- packagelists/amd64/pg18.4-spock5.0.8-minimal.txt
- packagelists/arm64/pg16.14-spock5.0.8-minimal.txt
- packagelists/amd64/pg17.10-spock5.0.8-minimal.txt
- packagelists/arm64/pg17.10-spock5.0.8-minimal.txt
maqeel75
changed the title
moizpgedge
left a comment
moizpgedge
left a comment
There was a problem hiding this comment.
Ran the image suite on all 6 images (16.14/17.10/18.4 × standard+minimal) — all pass; Postgres + Patroni boot and all extensions work.
Diff looks good: versions consistent across all packagelists (spock 5.0.9, PG -2, both arches/flavors), build script + Dockerfile changes fine.
Verified against the Control Plane: 3-node 18.4 cluster reports Spock 5.0.9 on every node with working multi-active replication; 16.14 and 17.10 also deploy on 5.0.9.
2 participants
No description provided.